BREAKING CHANGE: drop EOL Node.js v18 and Electron v26, v27, and v28. Add node v24 to build matrix. #1371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes end-of-life Node.js v18 and Electron v26–v28 support, adds Node.js v24 to the build matrix, and enforces supported Node versions via package.json.
- Added a new
engines.noderange topackage.json - Updated GitHub Actions workflows to drop Node v18 and use Node v20 (and include v24 in the build matrix)
- Revised the prebuild commands and comments in
build.ymlto reflect the new supported versions
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Introduce "engines": { "node": "20.x || 22.x || 23.x || 24.x" } |
| .github/workflows/update-sqlite.yml | Change setup-node from Node 18 → Node 20 |
| .github/workflows/bump-version.yml | Change setup-node from Node 18 → Node 20 |
| .github/workflows/build.yml | Remove Node 18, add Node 24 to matrix; update build commands & comments |
Comments suppressed due to low confidence (1)
.github/workflows/build.yml:33
- [nitpick] To avoid version drift, consider extracting the Node.js version list into a shared matrix or workflow template so all jobs stay in sync when adding/removing versions.
- - 18
JoshuaWise
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't done any verification of this branch. We'll see how GHA likes it.